improve test covr #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bobluppes
reviewed
May 22, 2023
There was a problem hiding this comment.
Thanks a lot for working on this, looks great 😃
I would not change the .gitignore in this PR, but once that it adressed I would be happy to merge. Also added a small comment on the exception tests, you can choose whether you want to address it or leave as-is.
Tagging #8 as this addresses part of the issue.
Co-authored-by: Bob Luppes <bobluppes@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
============================================
+ Coverage 72.97% 100.00% +27.02%
============================================
Files 3 8 +5
Lines 74 395 +321
Branches 22 0 -22
============================================
+ Hits 54 395 +341
+ Misses 7 0 -7
+ Partials 13 0 -13
☔ View full report in Codecov by Sentry. |
bobluppes
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request includes changes that augment the test coverage to
78.38%, with a focus on thegraph_testfile.The changes in the pull request encompass the following:
Addition of new test cases to cover the graph module.
Improvement of existing test cases to include edge cases and handle exceptions appropriately.
I have ensured that all tests pass successfully,